When a singer sings a song, they are connecting with an audience on an emotional level (or attempting to). When a singer shatters a glass with his voice (Like in Mythbusters) he's showing off. When a sprinter is in a race, he's competing. When he just films himself sprinting to show how fast he's going, he's showing off. When there's no point other than showing what one can do, it's showing off. And I have no problem with it. It's not about, "Don't do that, you're just showing off" it's about knowing what you're doing so you can do it as well as possible. If you're going to show off, show off in such a way that it is the best display of the skills you are showing off. If you don't want to show off, then you need an entirely different approach to the video. But you can't know that until you've understood that the point of the video is to show off.
How they play depends entirely on the end goal of the video. If your goal was to show some really powerful magic, then sorry, you failed. None of the stuff shown (though well executed) was powerful as it had no emotional resonance. It will be forgotten shortly after viewing. Much like those video compilations of people doing really amazing things like the kid in the wheel chair doing a back flip off a skate ramp, or the high dive into a kiddy pool, etc. (which I freely admit I really enjoy watching), it doesn't leave a lasting impact. Which is fine, if you weren't looking to leave a lasting impact. Sometimes it's good to just make a video that shows you (and a friend, in this case) showing off some hard earned skill.
As to the popularity of full performance videos, I have to ask, how do you know? I don't spend a lot of time browsing through internet videos of magicians, so I have no definitive information on this .. but has a flourishing video ever gone viral? I can think of two magic videos, from two very different and not all that famous performers that have. Also, those videos spread beyond the normal viewership for those performers. Which also negates your last point, that full performances are only enjoyed by magicians. I disagree entirely. A good performance will be enjoyed by most people. Otherwise David Blaine wouldn't be as successful as he is. What you're referring to are bad performance videos, which the internet is chock full of. Few people enjoy watching those, but not because they are full performances, rather because they are boring. Just like people don't like watching boring performances in person, they don't like watching them on video either.
Now that I know what your video is for, I can give my advice. I still can't help with clothing, as I just don't have the mind for it. When I want to make sure my clothing will be right for what I'm doing, I ask my girlfriend.
As I said, I think the music is a good choice. On repeated viewings, the song is even growing on me. I think you need to show your face(s) more, though. You're showing the skills you've developed, make sure people can see who it is. This might just mean adjusting the angle of the camera to have a face in the shot, or it might mean adjusting the whole body stance. You definitely had some points where the stuff you were doing was lining up with the music, which is good, but I don't know if it was on purpose or a happy accident. Try to do that as much as possible. The human brain will give a tiny burst of happy brain chemicals every time it predicts something that comes true (Which is why pop music is so popular and also so predictable). If we can tell a big beat is coming up, and something happens on that beat, it makes us happy. Also, it's more visually pleasing when the actions we see on screen are matching up with the music we're hearing either via lyrics or beat. The more of that stuff that is in your videos, the happier the videos will make people on a base level, which means they'll watch more and show it to more people.
On a technical note, you need to reduce the finger flutter of your left hand while doing passes. Perhaps try curling the index finger under the deck.
I guess we were emulating the Zach Mueller type of video, which we really enjoyed.
