1. The Prestige
2. The Illusionist
3. Magicians (It is a british film about a magic convention, very funny)
4. Smokin Aces
5. Shade
6. Next (Nick Cage plays a magician, not much magic, but still interesting)
The harry potter series
Kiss kiss,bang bang (robert downey jr.as a kid magician)
The Dark Knight(pencil trick)
el laberinto del fauno(pans labyrinth)..its 'real'magic not our kind.but a great film
Revolver(no magic but psychological film.and gambling)
Smokin' aces has a few flourishes by Dan(or dave)performing them.
And of course the prestige and the illusionist.
"Shade" is a good magic movie. I was actually an extra in it! There was a scene they filmed at Hollywood's Magic Castle and they had an actor playing Dai Vernon himself. (But they called him (The Professor".) This is the scene I was in as well because they wanted real magicians for it! Check it out!